On 06/06/2012 01:43 PM, Arend van Spriel wrote: > On 06/06/2012 01:07 AM, Hauke Mehrtens wrote: >> --- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c >> +++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c >> @@ -209,9 +211,11 @@ void write_radio_reg(struct brcms_phy *pi, u16 addr, u16 val) >> bcma_write16(pi->d11core, D11REGOFFS(phy4wdatalo), val); >> } >> >> - if (++pi->phy_wreg >= pi->phy_wreg_limit) { >> - (void)bcma_read32(pi->d11core, D11REGOFFS(maccontrol)); >> - pi->phy_wreg = 0; >> + if (sii->icbus->hosttype == BCMA_HOSTTYPE_PCI) { >> + if (++pi->phy_wreg >= pi->phy_wreg_limit) { >> + (void)bcma_read32(pi->d11core, D11REGOFFS(maccontrol)); >> + pi->phy_wreg = 0; >> + } >> } > > You can loose the outer curly braces or combine into one if statement. > Same for the other code fragment in this patch. Combining them sounds good. > > Gr. AvS > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html