On 06/06/2012 02:19 PM, Florian Fainelli wrote: > Hi Hauke, > > On Tuesday 05 June 2012 23:55:05 Hauke Mehrtens wrote: >> The SoCs do not need any special handling in bcma_pmu_pll_init(), >> bcma_pmu_resources_init(), bcma_pmu_swreg_init() and >> bcma_pmu_workarounds. This patches suppresses some warnings in the log. > > This does not look like it scales very good, how about you turn the pr_err() > into a pr_debug() so that developpers porting bcma on a new chip need to turn > on the appropriate debug knobs to get the message? I would more like to remove this message completely so that the default case does nothing. A developer should be capable of finding this function without any debug message when he wants to add support for a new device. >> Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx> >> --- >> drivers/bcma/driver_chipcommon_pmu.c | 32 > ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/drivers/bcma/driver_chipcommon_pmu.c > b/drivers/bcma/driver_chipcommon_pmu.c >> index 2ebba9c..9bf2dff 100644 >> --- a/drivers/bcma/driver_chipcommon_pmu.c >> +++ b/drivers/bcma/driver_chipcommon_pmu.c >> @@ -63,6 +63,14 @@ static void bcma_pmu_pll_init(struct bcma_drv_cc *cc) >> case BCMA_CHIP_ID_BCM4331: >> case BCMA_CHIP_ID_BCM43224: >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("PLL init unknown for device 0x%04X\n", >> @@ -83,6 +91,14 @@ static void bcma_pmu_resources_init(struct bcma_drv_cc > *cc) >> case BCMA_CHIP_ID_BCM4331: >> case BCMA_CHIP_ID_BCM43224: >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("PMU resource config unknown for device 0x%04X\n", >> @@ -105,6 +121,14 @@ static void bcma_pmu_swreg_init(struct bcma_drv_cc *cc) >> case BCMA_CHIP_ID_BCM4331: >> case BCMA_CHIP_ID_BCM43224: >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("PMU switch/regulators init unknown for device " >> @@ -168,6 +192,14 @@ static void bcma_pmu_workarounds(struct bcma_drv_cc > *cc) >> } >> break; >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("Workarounds unknown for device 0x%04X\n", >> -- >> 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html