On 06/06/2012 01:07 AM, Hauke Mehrtens wrote: > brcms_c_chipmatch() just works for PCIe devices and returns false for > non PCIe devices. This stops brcms_ops_stop() from calling it when the > devices is not a PCIe device. Although this is true you may want to consider what this function provides. The intent is to have a more accurate filter to determine support the device by the driver, ie. more accurate than what is in the driver device table. So in brcms_c_chipmatch() we may want a host-type independent filtering and validate bcma_device_id, bcma_chipinfo, and possibly bcma_boardinfo. > Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx> > --- > .../net/wireless/brcm80211/brcmsmac/mac80211_if.c | 22 +++++++++++++------- > 1 file changed, 14 insertions(+), 8 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html