Search Linux Wireless

Re: [RFC 01/14] cfg80211: respect intf combinations for 1 interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-06-06 at 10:56 +0200, Michal Kazior wrote:
> Johannes Berg wrote:
> > On Mon, 2012-05-28 at 13:18 +0200, Michal Kazior wrote:
> >> Don't ignore interface combinations when only one
> >> interface is up. Otherwise we may call a driver to
> >> create (or change) interface type to something it
> >> didn't report in interface combinations it
> >> reported.
> >
> > We still check wiphy.interface_modes before we even go into this
> > function, no? Arguably we should move the check into the function, but
> > I'm not sure what you're fixing here.
> 
> Suppose a driver advertises support for AP and STA. Without the patch 
> it's possible to bring up e.g. IBSS interface.

I don't think so?

main.c:1005
        case NETDEV_PRE_UP:
                if (!(wdev->wiphy->interface_modes & BIT(wdev->iftype)))
                        return notifier_from_errno(-EOPNOTSUPP);

But it does make sense to move that into the function.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux