On Mon, 2012-05-28 at 13:18 +0200, Michal Kazior wrote:
> Don't validate interface combinations on a stopped
> interface. Otherwise we might end up being able to
> create a new interface with a certain type, but
> won't be able to change an existing interface
> type.
>
> This also skips some other functions when
> interface is stopped when changing interface type.
>
> Change-Id: I02af110905184c8182aa30dc9054a2c53f0238d0
> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx>
> ---
> net/wireless/util.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/wireless/util.c b/net/wireless/util.c
> index 147f283..eb7ca3c 100644
> --- a/net/wireless/util.c
> +++ b/net/wireless/util.c
> @@ -805,7 +805,7 @@ int cfg80211_change_iface(struct cfg80211_registered_device *rdev,
> ntype == NL80211_IFTYPE_P2P_CLIENT))
> return -EBUSY;
>
> - if (ntype != otype) {
> + if (ntype != otype && netif_running(dev)) {
Yeah, makes sense, can you send it separately for 3.5?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
