On Thu, May 10, 2012 at 12:46:10PM +0300, Kalle Valo wrote: > Hi Soumik, > > Soumik DAS <soumik.das@xxxxxxxxxxxxxx> writes: > > > In some cases the sequence of events gets changed - > > a. call ieee80211_send_nullfunc() > > (current thread gets scheduled out/pre-empted at this point) > > b. null frame gets transmitted and acked > > c. probe_send_count is incremented > > d. mac80211 waits for some specified timeout and checks that probe_send_count is still > 0. It concludes that AP did not acknowledge the null frame and disassociates from the current AP. > > e. After a scan STA again re-associate with the same AP. > > Ok, so there's a race in mac80211? You should describe the race in the > commit log so that a random developer understands what's happening. It > doesn't need to be anything fancy, usually just few sentences is enough > to give sufficient background for the patch. Where the race is, how > often it happens and how to fix it properly, that sort of things. > > I repeat this a lot (sorry!) but the most important question the commit > log should answer is "Why?". The question "What?" isn't actually that > important as anyone can read the patch themselves. > > -- > Kalle Valo Soumik, Are you going to repost with a proper changelog? John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
