Hi, > This is a driver for the S3FHRN2 NFC device. the driver is just a > proxy getting SHDLC/HCI frames from a userspace stack. <snip> > + > + info->miscdev.minor = MISC_DYNAMIC_MINOR; > + info->miscdev.name = S3FHRN2_DRIVER_NAME; > + info->miscdev.fops = &s3fhrn2_fops; > + info->miscdev.parent = &client->dev; > + ret = misc_register(&info->miscdev); > + if (ret < 0) { > + dev_err(&client->dev, "failed to register Device\n"); > + goto err_dev_reg; > + } instead of creating a misc character device, I would prefer that this gets integrated as driver for the NFC subsystem. We do not want to have shim NFC drivers in the kernel anymore. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html