On Sun, 2012-06-03 at 23:30 +0300, Arik Nemtsov wrote: > +++ b/net/mac80211/rx.c > @@ -3023,6 +3023,9 @@ void ieee80211_rx(struct ieee80211_hw *hw, struct sk_buff *skb) > if (WARN_ON(!sband)) > goto drop; > > + /* make sure we get the latest values for the next variable checks */ > + smp_rmb(); > + That doesn't make a lot of sense I think? This entire thing is inherently racy, you could be processing RX already even while just setting the variable in the other code. I'm not really sure what the effect of this here is, but it's certainly a hot-path. > + /* > + * Stop all Rx during the reconfig. We don't want state changes > + * or driver callbacks while this is in progress. > + */ > + local->in_reconfig = true; > + smp_wmb(); If anything, you should probably put this right into ieee80211_restart_hw() rather than the reconfig function? It's not needed for suspend/resume anyway since we check that separately. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
