Search Linux Wireless

Re: [PATCH] mac80211: clear ifmgd->bssid only after building DELBA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2012-06-01 at 11:14 +0300, Eliad Peller wrote:
> ieee80211_set_disassoc() clears ifmgd->bssid before
> building DELBA frames, resulting in frames with invalid
> bssid ("00:00:00:00:00:00").
> 
> Fix it by clearing ifmgd->bssid only after building
> all the needed frames.
> 
> After this change, we no longer need to save the
> bssid (before clearing it), so remove the local array.

I'm not convinced clearing the BSSID this late is correct, there's a lot
of code using it, for example comparing it on RX, that we may not want
to have it at this point any more.

It may well be that this is no longer a concern, but I wouldn't dismiss
it right away.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux