On Sun, May 27, 2012 at 02:17:03PM +0200, Arend van Spriel wrote: > >> can this be moved in brcms_c_channel_mgr_attach()? > > > > Not without rearranging the initialization, as brcms_c_regd_init() must > > be called after wiphy->bands has been set up. I don't see any reason why > > setting up the bands couldn't be moved to before channel_mgr_attach() > > though, and in that case regd_init() could be moved into > > channel_mgr_attach(). > > Please do. I prefer to keep regd_init() local to channel.c. Further inspection revealed dependencies here that I missed the first time. ieee_hw_rate_init() relies on a couple of things done in brcms_c_attach(), which is calling the channel_mgr_attach() function. As far as I can tell we could still run ieee_hw_init() before channel_mgr_attach(), but we need the first half of brcms_c_attach() to run first. So our options seem to be either calling ieee_hw_init() from brcms_c_attach() or breaking up brcms_c_attach() into two parts and calling ieee_hw_init() in the middle. Or else calling brcms_c_regd_init() from brcms_attach() as I have it now. What's your preference? Thanks, Seth -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
