On Thu, 2012-05-31 at 09:07 +0300, Eliad Peller wrote: > On Wed, May 30, 2012 at 4:57 PM, Eliad Peller <eliad@xxxxxxxxxx> wrote: > > On Wed, May 30, 2012 at 4:50 PM, Johannes Berg > > <johannes@xxxxxxxxxxxxxxxx> wrote: > >> On Wed, 2012-05-30 at 16:44 +0300, Eliad Peller wrote: > >>> On Wed, May 30, 2012 at 4:16 PM, Johannes Berg > >>> <johannes@xxxxxxxxxxxxxxxx> wrote: > >>> > When any interface goes down, it could be the one that > >>> > we were doing off-channel with. Thus, we need to flush > >>> > the offchannel start/stop work so they can't run when > >>> > the interface has already been removed from the driver > >>> > or even been destroyed. It's OK to flush them even if > >>> > they were for another interface, that just means that > >>> > we potentially delay the interface down a little bit. > >>> > > >>> can't we check hw_roc_dev? > >> > >> We could, but it didn't seem worthwhile. Think I should do that instead? > >> > > hmm... i guess it doesn't really matter :) > > > just gave it a second thought - the driver might have not even called > ieee80211_ready_on_channel() yet, so i think it's still racy. Hmmm. Good point. For some reason I thought that wouldn't happen, but I guess you're right. I'll need to think more about how we can fix that though. Maybe cfg80211 could request a cancel when the corresponding interface goes down? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
