Search Linux Wireless

Re: [PATCH] rt2x00: Add support for RT5360 based PCI devices.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jakub,

On 15 mei 2012, at 12:22, Jakub Kicinski <kubakici@xxxxx> wrote:

> Hi,
> 
> On Thu, 10 May 2012 14:27:33 +0200 Gertjan van Wingerde <gwingerde@xxxxxxxxx> wrote:
>> From: Alex Villací­s Lasso <a villacis@xxxxxxxxxxxxx>
>> 
>> This chip is used at least by the D-Link DWA-525 adapter.
> 
> I have some concerns regarding this patch. 
> 
> First of all Gertjan, I think you removed define of RF5360 and it
> doesn't compile now ;-)

Ouch. Don't know what happened here, as I have compile tested it and tested it with an actual card. Probably something went wrong when merging in the tree that I use to generate and send patches.
Will send a v2 tomorrow, when I return home.

> 
> Secondly looking at legacy driver, 5360 is just another PCI ID of 5390
> family, do we really need to add all these cases? I think maybe adding
> PCI ID, as Zero Lin did recently with 539b will be sufficient? 

This is really needed. For some reason Ralink are separating the RF definitions here, even though they are all programmed the same.
I do own the D-Link card I mentioned in the commit message, and testing has shown these cases are needed.
Apparently it is not needed for the 539b.

---
Gertjan--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux