Hi Kalle, On Thu, 2012-05-10 at 12:50 +0300, Kalle Valo wrote: > Arik Nemtsov <arik@xxxxxxxxxx> writes: > > > This series adds initial support for the 18xx chip family. The new > > module uses wlcore for functionality common with the 12xx family. > > You do know that sending 78 patches in one patchset is very much > frowned upon? No sane person (outside of wl12xx) is going to review > all of these. Yes, I totally agree with you. I have been trying to send all this stuff in smaller batches that would be much easier to review and manage upstream. We wanted to squash many of them, clean things up a bit more and so on, but we diverged so much from the mainline (we had close to 100 patches dragging in our internal trees) that all the rebases and even small squashes or moving patches around became a horrible nightmare. As you know, I've been on sick leave for a while, so all this work would have dragged even longer if Arik and the rest of the team didn't take an action to get it out. To conclude, even though I don't like the way this was done, now it's done and sending this series again in smaller batches would just make things worse, because not only there would still be a huge bunch of patches in total, most of them would actually be duplicate or just slightly modified. So, unless you or someone else really disagrees, I'll apply these to the wl12xx.git tree. And then I'll go find Arik to remove some of his fingernails, especially the one on his right hand pinky so he can't hit ENTER so quickly after typing git send-email. :P -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
