Search Linux Wireless

Re: [PATCH] rt28xx: Revert eccc068e8e84c8fe997115629925e0422a98e4de which causes txpower to be stuck at 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Helmut Schaa wrote:
> Luis, with rt2800 we are not really able to provide an accurate max tx power :(
> so, can we restore the previous behavior in reg.c? Or maybe do something like
> 
> if (chan->max_reg_power)
>   chan->max_power = min(chan->max_power, chan->max_reg_power);
> 
> Tobias, does that work for you as well?

Nope, the problem is that chan->max_power is 0, so this will work:

if (chan->max_power == 0)
  chan->max_power = chan->max_reg_power;
else
  chan->max_power = min(chan->max_power, chan->max_reg_power);

Also, in the if-branch above that chan->max_reg_power is never set, I
wonder if that should be

chan->max_power = chan->orig_mpwr = chan->max_reg_power =
  (int) MBM_TO_DBM(power_rule->max_eirp);

instead of

chan->max_power = chan->orig_mpwr =
  (int) MBM_TO_DBM(power_rule->max_eirp);

(But I don't seem to hit that if-block juding from some printks I added)

-- 
Tobias						PGP: http://8ef7ddba.uguu.de
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux