Search Linux Wireless

Re: [PATCHv2 12/21] cw1200: sta.*, mac80211 STA callbacks.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 03, 2012 at 11:59:14AM +0200, Dmitry Tarnyagin wrote:
> >[...]
> >>+	spin_lock(&priv->event_queue_lock);
> >>+	list_splice_init(&priv->event_queue,&list);
> >>+	spin_unlock(&priv->event_queue_lock);
> >>+	__cw1200_free_event_queue(&list);
> >...and then you won't need to do the above?
> I'm not sure I understand the question :(.

On second reading this code is fine, I just mis-understood it the first
time around.  Sorry for the noise.

> >>+	if (priv->listening ^ listening) {
> >That's a unusual (to me anyway) way to spell "a != b".  On my
> >version of gcc, generated code is exactly the same.
> Yes, true. It looked quite natural for me at 00:16. Pach is welcome.

Ok, I'll send on a couple of patches for these minor changes -- thanks!

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux