Search Linux Wireless

Re: [PATCHv2 12/21] cw1200: sta.*, mac80211 STA callbacks.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bob,

On Sun, Apr 29, 2012, Bob Copeland wrote:


+	while (!list_empty(list)) {
[...]

I think perhaps you can use list_for_each_entry_safe() here...
It's the same. Yes, list_for_each_entry_safe() can be used here as well.

+	LIST_HEAD(list);
[...]
+	spin_lock(&priv->event_queue_lock);
+	list_splice_init(&priv->event_queue,&list);
+	spin_unlock(&priv->event_queue_lock);
+	__cw1200_free_event_queue(&list);
...and then you won't need to do the above?
I'm not sure I understand the question :(.

+	if (priv->listening ^ listening) {
That's a unusual (to me anyway) way to spell "a != b".  On my
version of gcc, generated code is exactly the same.
Yes, true. It looked quite natural for me at 00:16. Pach is welcome.

With best regards,
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux