On Friday 27 April 2012 12:04 PM, Kalle Valo wrote:
On 04/27/2012 07:09 AM, Vasanthakumar Thiagarajan wrote:
bus_req = ath6kl_sdio_alloc_busreq(ar_sdio);
- if (!bus_req)
+ if (!bus_req) {
+ ath6kl_err("Ran out of bus request buffer for tx\n");
return -ENOMEM;
+ }
I'm not sure about this one. There's a risk that this will spam the log.
Should it be a debug message instead? Or should we have instead
ath6kl_err_ratelimit()?
This condition is very rare, I found it only through code review. I'm
pretty sure we don't hit this very often.
I'm not worried how often it happens, I'm just worried that _when_ it
happens the warning might make things worse. For example, I personally
saw a case where flood of warnings prevented watchdog heartbeat from
happening which caused the whole system to reboot. Without the warnings
system would have worked just fine, just a bit more slowly.
Fair enough.
Is it ok for you if I change the ath6kl_err() to WARN_ON_ONCE() (or
WARN_ONCE() if you prefer to keep the warning message)? This should be a
rare event anyway.
I'm fine with that, thanks.
Vasanth
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
