On Thursday 26 April 2012 11:51 PM, Kalle Valo wrote:
On 04/26/2012 05:56 PM, Vasanthakumar Thiagarajan wrote:
Return status of ath6kl_htc_tx_issue() is ignored in
ath6kl_htc_tx_from_queue(), but failed tx packet is
is not cleaned up. To fix memory leak in this case, call
completion with error. Also, throw an error debug message
when tx fails in ath6kl_sdio_write_async() due to shortage
in bus request buffer.
Signed-off-by: Vasanthakumar Thiagarajan<vthiagar@xxxxxxxxxxxxxxxx>
[...]
bus_req = ath6kl_sdio_alloc_busreq(ar_sdio);
- if (!bus_req)
+ if (!bus_req) {
+ ath6kl_err("Ran out of bus request buffer for tx\n");
return -ENOMEM;
+ }
I'm not sure about this one. There's a risk that this will spam the log.
Should it be a debug message instead? Or should we have instead
ath6kl_err_ratelimit()?
This condition is very rare, I found it only through code review. I'm
pretty sure we don't hit this very often.
Vasanth
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
