Search Linux Wireless

Checkpatch warnings with pr_fmt()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joe,

due to checkpatch warnings in ath6kl, from a recent pr_fmt() addition, I
had to update checkpatch and now I get lots of useless warnings like this:

drivers/net/wireless/ath/ath6kl/common.h:28: CHECK: Don't begin block
comments with only a /* line, use /* comment...
drivers/net/wireless/ath/ath6kl/bmi.h:233: CHECK: No space is necessary
after a cast

IMHO they are wrong, at least the style I have tried to enforce in
ath6kl is totally opposite (I have "/*\n" on multiline comments and a
space after a cast). And at least CodingStyle seems to recommend my
style for the multiline comments.

Would you consider removing these two warnings? Or maybe add a new check
level so that I can easily disable them?

As I get a lot of patches from people not familiar with the Linux coding
style checkpatch is a valuable tool for me, I cannot spot all the style
issues by just reviewing the patches. But now checkpatch is useless for
me as the real warnings get buried within the noise.

Kalle
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux