Hi, Javier > 1. I would suggest rewording the description. Maybe something like: > > "Record the RANN sender's address only for RANNs that meet the > acceptance criteria (per sections 13.10.12.4.2)." Noted, your description is clearer. > 2. Also, to properly review the patch, I had to find your earlier > patch (http://lists.open80211s.org/pipermail/devel/2012-March/003113.html) > that's still in John's queue. Maybe merge the two patches and > resubmit? I have found out that the previous patches are merged upstream 5 hours ago. > 3. Before your patch, the address in rann_snd_addr was always valid if > mpath->is_root == true. This is why elsewhere in the code you could > safely do things like: > > da = (mpath && mpath->is_root) ? mpath->rann_snd_addr : broadcast_addr; > > This is no longer the case, at least not evidently. Can you double > check that the possibility where mpath->is_root == true and > mpath->rann_snd_addr is uninitialized is correctly addressed? Maybe > by initializing mpath->rann_snd_addr to be the broadcast address? > Ok, I will take a look on this. Perhaps, adding it on the mesh_path_add routine. > 4. The comment /* Using individually addressed PREQ for root node */ > does not make sense there. I think it's ok to remove, or reword as /* > Recording RANNs sender address to send individually addressed PREQs > destined for root node */ Noted. Regards, Chun-Yeow -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
