On Fri, Apr 6, 2012 at 9:01 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > Today, stations are added already associated. That is > inefficient if, for example, the driver has no room > for stations any more because then the station will > go through the entire auth/assoc handshake, only to > be kicked out afterwards. > > To address this a bit better, at least with drivers > using the new station state callback, allow hostapd > to add stations in unauthenticated mode, just after > receiving the AUTH frame, before even replying. Thus > if there's no more space at that point, it can send > a negative auth frame back. It still needs to handle > later state transition errors though, of course. > > Completely untested so far, just wanted to see what > everybody thinks. I'll need to work on the hostapd > patch as well, but I think TI had something there to > fix a race which I need to look into. > The patch looks good -- i agree it's better to add the station as soon as possible. in our internal hostap tree, we use the following patches: https://github.com/TI-OpenLink/hostap/commit/44e8fd28f9b2fc8da9c6f58a2731b4ffa65bc396 (https://github.com/TI-OpenLink/hostap/commit/bf21f3fe7541cd17b7b92aaf6bf06a00e9ec28bb) These patches handle the race in which the EAPOL Start from the client comes before the association response tx result, causing the EAPOL to get dropped. The first patch simply adds the station before sending the association response. I guess that with the suggested patch we'll just have to set the ASSOC state (before sending assoc response) instead of adding the station (which will be done before sending auth response, i guess). Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
