On Wed, Apr 4, 2012 at 8:12 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2012-04-04 at 20:08 +0530, Mohammed Shafi wrote: >> Hi Johannes, >> >> On Wed, Apr 4, 2012 at 5:14 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >> > From: Johannes Berg <johannes.berg@xxxxxxxxx> >> > >> > In WoWLAN, we only get the triggers when we actually get >> > to suspend. As a consequence, drivers currently don't >> > know that the device should enable wakeup. However, the >> > device_set_wakeup_enable() API is intended to be called >> > when the wakeup is enabled, not later when needed. >> > >> > Add a new set_wakeup() call to cfg80211 and mac80211 to >> > allow drivers to properly call device_set_wakeup_enable. >> >> should we take care of anything else apart from >> device_set_wakeup_enable in this driver >> callback. we are working in ath9k WoW and i had seen the drivers use >> device_set_wakeup_enable >> API in the suspend/resume path. thank you. > > Yeah, I also did it in the suspend/resume path but Rafael told me that > was wrong. As the PM maintainer, he should know :-) oh ok, thanks for the reply and the letting me know the reason! > > I don't think you need to do anything else in this callback. > > johannes > -- thanks, shafi -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
