Hi Marek, On Thu, Mar 22, 2012 at 3:33 AM, Marek Lindner <lindner_marek@xxxxxxxx> wrote: > > Hi, > > I am not familiar with the 802.11s code and could be totally wrong here but .. > > > On Thursday, March 22, 2012 13:56:08 Chun-Yeow Yeoh wrote: >> + if ((mpath->sn < orig_sn || (mpath->sn == orig_sn && > > .. this sequence number handling looks broken to me. What happens when the > sequence number wraps around ? One could be smaller than the other and still > be newer. > I know this isn't really what your patch changes. > > >> #define SN_GT(x, y) ((long) (y) - (long) (x) < 0) >> #define SN_LT(x, y) ((long) (x) - (long) (y) < 0) > > Your macros tried to address the problem but casting your sequence number to > long also breaks the wrap around. Ah, thanks for your help. I guess we do need those macros after all but they'd have to be re-written as #define SN_LT(x, y) ((s32)(x - y) < 0) #define SN_GT(x, y) ((s32)(x - y) > 0) And since this is just to handle wrap arounds, there is no need for the new SN_EQ that was suggested earlier. Cheers, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
