Search Linux Wireless

Re: [PATCH v2] mac80211: fix the RANN propagation issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I am not familiar with the 802.11s code and could be totally wrong here but ..


On Thursday, March 22, 2012 13:56:08 Chun-Yeow Yeoh wrote:
> +       if ((mpath->sn < orig_sn || (mpath->sn == orig_sn &&

.. this sequence number handling looks broken to me. What happens when the 
sequence number wraps around ? One could be smaller than the other and still 
be newer.
I know this isn't really what your patch changes.


>  #define SN_GT(x, y) ((long) (y) - (long) (x) < 0)
>  #define SN_LT(x, y) ((long) (x) - (long) (y) < 0)

Your macros tried to address the problem but casting your sequence number to 
long also breaks the wrap around.

Regards,
Marek
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux