Search Linux Wireless

Re: [PATCH v2] mac80211: Add iface name when calling WARN-ON

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2012-03-15 at 11:40 -0700, greearb@xxxxxxxxxxxxxxx wrote:
> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
> 
> This lets the user know which interface has failed
> the check_sdata_in_driver check.
> 
> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
> ---
> :100644 100644 af4691f... 43e95f0... M	net/mac80211/driver-ops.h
>  net/mac80211/driver-ops.h |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/net/mac80211/driver-ops.h b/net/mac80211/driver-ops.h
> index af4691f..43e95f0 100644
> --- a/net/mac80211/driver-ops.h
> +++ b/net/mac80211/driver-ops.h
> @@ -7,7 +7,11 @@
>  
>  static inline void check_sdata_in_driver(struct ieee80211_sub_if_data *sdata)
>  {
> -	WARN_ON(!(sdata->flags & IEEE80211_SDATA_IN_DRIVER));
> +	if (unlikely(!(sdata->flags & IEEE80211_SDATA_IN_DRIVER))) {
> +		printk(KERN_ERR "%s:  Failed check-sdata-in-driver check, flags: 0x%x\n",
> +		       sdata->dev->name, sdata->flags);
> +		WARN_ON(!(sdata->flags & IEEE80211_SDATA_IN_DRIVER));
> +	}

Please use WARN() instead of WARN_ON() to make the message part of the
warning.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux