Hi Johannes,
> On Thu, 2012-03-15 at 19:19 +0100, Johannes Berg wrote:
> > Hi,
> >
> > > For mwifiex part, the change looks fine except for a couple checkpatch warnings.
> >
> > Ok, thanks. I knew there were going to be checkpatch warnings but
> > decided that the code wasn't going to be easier to read if I forced it
> > down to 80 colums, so decided to leave them.
>
> I should say that I am, of course, happy to change it if you'd like me
> to.
There is also a checkpatch ERROR in net/mac80211/mlme.c:226:
- (hti->ht_param & IEEE80211_HT_PARAM_CHAN_WIDTH_ANY)) {
- switch(hti->ht_param & IEEE80211_HT_PARAM_CHA_SEC_OFFSET) {
+ (ht_oper->ht_param & IEEE80211_HT_PARAM_CHAN_WIDTH_ANY)) {
+ switch(ht_oper->ht_param & IEEE80211_HT_PARAM_CHA_SEC_OFFSET) {
WARNING: line over 80 characters
ERROR: space required before the open parenthesis '('
Could you please fix this?
For the warnings in mwifiex, it’s nicer if you can fix it in this patch. Or, I can fix it later in a separate patch.
Thanks,
Bing
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
