On Thu, Mar 15, 2012 at 04:26:43PM +0100, Johannes Berg wrote: > On Thu, 2012-03-15 at 11:03 -0400, John W. Linville wrote: > > On Thu, Mar 15, 2012 at 03:47:14PM +0100, Johannes Berg wrote: > > > On Thu, 2012-03-15 at 10:25 -0400, John W. Linville wrote: > > > > On Thu, Mar 15, 2012 at 03:13:25PM +0100, Johannes Berg wrote: > > > > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > > > > > > > The station signal value is supposed to be in dBm > > > > > which the device can't give, so don't report it. > > > > > > > > > > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > > > > > Won't this break functionality for users of this device? > > > > > > I don't know if it breaks functionality, but filling in values in the > > > wrong units doesn't seem like a good plan. > > > > No, but if it isn't actually hurting anyting then I would rather > > change a comment or two (and perhaps augment the nl80211 code) than > > to simply break things for users. > > > > FWIW, cfg80211_wireless_stats has been able to cope with the > > unspecified units since it was implemented in commit 8990646d. > > Maybe that was a bug but it is a user-visible one that has been around > > for years now... > > Interesting, I had no idea. I was more concerned with the actual nl80211 > exporting (nl80211_send_station), not wext. Seems like something like > this patch would be sufficient then: > http://p.sipsolutions.net/ca88e4afc69683ca.txt > > Of course, we could add nl80211 attributes for unspec in the station > info too. Yes, I came-up with something similar -- patch to follow... John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
