On Thu, Mar 15, 2012 at 03:13:25PM +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@xxxxxxxxx>
>
> The station signal value is supposed to be in dBm
> which the device can't give, so don't report it.
>
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
Won't this break functionality for users of this device?
> ---
> drivers/net/wireless/rndis_wlan.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> --- a/drivers/net/wireless/rndis_wlan.c 2012-03-10 09:17:00.000000000 +0100
> +++ b/drivers/net/wireless/rndis_wlan.c 2012-03-15 15:11:52.000000000 +0100
> @@ -2505,7 +2505,7 @@ static int rndis_set_default_key(struct
> static void rndis_fill_station_info(struct usbnet *usbdev,
> struct station_info *sinfo)
> {
> - __le32 linkspeed, rssi;
> + __le32 linkspeed;
> int ret, len;
>
> memset(sinfo, 0, sizeof(*sinfo));
> @@ -2516,13 +2516,6 @@ static void rndis_fill_station_info(stru
> sinfo->txrate.legacy = le32_to_cpu(linkspeed) / 1000;
> sinfo->filled |= STATION_INFO_TX_BITRATE;
> }
> -
> - len = sizeof(rssi);
> - ret = rndis_query_oid(usbdev, OID_802_11_RSSI, &rssi, &len);
> - if (ret == 0) {
> - sinfo->signal = level_to_qual(le32_to_cpu(rssi));
> - sinfo->filled |= STATION_INFO_SIGNAL;
> - }
> }
>
> static int rndis_get_station(struct wiphy *wiphy, struct net_device *dev,
>
>
>
--
John W. Linville Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
