On 03/07/2012 07:20 AM, Raja Mani wrote: > On Tuesday 06 March 2012 09:42 PM, Kalle Valo wrote: > >>> + if (ret&& (!ar->wow_suspend_mode || >>> + ar->wow_suspend_mode == WLAN_POWER_STATE_DEEP_SLEEP)) >>> + try_deepsleep = true; >> >> I don't get this part. If the wow_mode parameter is set to 0 or 2 the >> functionality is the same, right? So what's the point with 0x2 the >> commit log? Deep sleep will be the default in disconnected anyway. >> Unless I misunderstood something, of course. > > Yes, the functionality is the same for both cases (0 or 2). > passing 2 to wow_mode is an explicitly option. > The value 0 is the default case. > > Should we remove option 2 in wow_mode and keep only > option 1 ? Thanks, now I understand. No need to change anything, I'll just clarify in the commit log that option 2 is the default as well. Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html