On 03/06/2012 11:33 AM, rmani@xxxxxxxxxxxxxxxx wrote: > From: Raja Mani <rmani@xxxxxxxxxxxxxxxx> > > It gives flexibility to the user to define suspend policy > when the suspend mode is set to WOW and the device is in > disconnected state at the time of suspend. > > New module parameter wow_mode is added to get the choice > from the user. This parameter is valid only if the module > parameter suspend_mode is set to WOW. > > To force WOW in connected state and cut power > in disconnected state: > suspend_mode=0x3 wow_mode=0x1 > > To force WOW in connected state and deep sleep > in disconnected state: > suspend_mode=0x3 wow_mode=0x2 > > If there is no value specified to wow_mode during insmod, > deep sleep mode will be tried in the disconnected state. > > Signed-off-by: Raja Mani <rmani@xxxxxxxxxxxxxxxx> [...] > + if (ret && (!ar->wow_suspend_mode || > + ar->wow_suspend_mode == WLAN_POWER_STATE_DEEP_SLEEP)) > + try_deepsleep = true; I don't get this part. If the wow_mode parameter is set to 0 or 2 the functionality is the same, right? So what's the point with 0x2 the commit log? Deep sleep will be the default in disconnected anyway. Unless I misunderstood something, of course. Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
