Search Linux Wireless

Re: [PATCH 3.3] rt2x00: fix random stalls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 06, 2012 at 08:45:21AM +0100, Helmut Schaa wrote:
> > -       if (!rt2x00queue_threshold(entry->queue))
> > +       if (!rt2x00queue_threshold(entry->queue)) {
> > +               spin_lock_irq(&entry->queue->tx_lock);
> >                rt2x00queue_unpause_queue(entry->queue);
> > +               spin_unlock_irq(&entry->queue->tx_lock);
> 
> Why do we need to disable interrupts here? spin_lock_bh should
> be sufficient.

I'm not 100% sure, and I was to lazy to find out, and chose safer
version. I guess I need to find out now ...

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux