Search Linux Wireless

re: {nl,cfg,mac}80211: Implement RSSI threshold for mesh peering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Ashok Nagarajan,

This is a semi-automatic email about new static checker warnings.

The patch 5533513784a8: "{nl,cfg,mac}80211: Implement RSSI threshold 
for mesh peering" from Feb 28, 2012, leads to the following Smatch 
complaint:

net/mac80211/mesh_plink.c:542 mesh_rx_plink_frame()
	 error: we previously assumed 'sta' could be null (see line 534)

net/mac80211/mesh_plink.c
   533		sta = sta_info_get(sdata, mgmt->sa);
   534		if (!sta && ftype != WLAN_SP_MESH_PEERING_OPEN) {
                    ^^^^
old check.

   535			mpl_dbg("Mesh plink: cls or cnf from unknown peer\n");
   536			rcu_read_unlock();
   537			return;
   538		}
   539	
   540		if (ftype == WLAN_SP_MESH_PEERING_OPEN &&
   541		    !sta_meets_rssi_threshold(sta, sdata)) {
                     ^^^^^^^^^^^^^^^^^^^^^^^^
new dereference.

   542			mpl_dbg("Mesh plink: %pM does not meet rssi threshold\n",
   543				sta->sta.addr);
                                ^^^^^
new dereference.
   544			rcu_read_unlock();

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux