Hi Arend, On Mon, Mar 5, 2012 at 20:31, Arend van Spriel <arend@xxxxxxxxxxxx> wrote: > On 03/04/2012 11:49 PM, Julian Calaby wrote: >> >> Hi Arend, >> >> On Sat, Mar 3, 2012 at 08:55, Arend van Spriel<arend@xxxxxxxxxxxx> wrote: >>> >>> The module init function of brcmfmac calls init functions for SDIO and >>> USB doing driver registration. This patch removes terminating the module >>> init when a driver registration for one host interface fails. >> >> >> Would it be better to fail the module load if *none* of them succeed - >> there's probably no point in having the module loaded if it's not >> actually hooked up to anything. >> > > Thanks, Julian > > However, the next patch in this series would undo the init code behaviour > you are proposing. The brcmf_sdio_init() already logs the failed driver > registration. I will add the same to brcmf_usb_init() in a separate patch. > Is that ok with you? I only skimmed the patch set and this is one of the bits that stuck out, I didn't really read what happened in the next patch. I didn't really care about the actual logging of failure - my point was more that if both fail then the module's still loaded, rather than failing and unloading - however, with the firmware loading being moved out of the module init path, there's no way to detect this anymore, so I suppose it doesn't matter. And yes, logging the probe error for USB would be a good thing. Thanks anyway, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
