Hi Arend,
On Sat, Mar 3, 2012 at 08:55, Arend van Spriel <arend@xxxxxxxxxxxx> wrote:
> The module init function of brcmfmac calls init functions for SDIO and
> USB doing driver registration. This patch removes terminating the module
> init when a driver registration for one host interface fails.
Would it be better to fail the module load if *none* of them succeed -
there's probably no point in having the module loaded if it's not
actually hooked up to anything.
You could write the init code like this:
static int __init brcmfmac_init(void)
{
int ret = 0;
bool loaded = false;
#ifdef CONFIG_BRCMFMAC_SDIO
ret = brcmf_sdio_init();
if (!ret)
loaded = true;
// An informative message could go here if it fails
#endif
#ifdef CONFIG_BRCMFMAC_USB
ret = brcmf_usb_init();
if (!ret)
loaded = true;
// An informative message could go here if it fails
#endif
if (!loaded)
return ret; // or -ENODEV
return 0;
}
And you then wouldn't have to change any of the other code.
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
