grrr, missed reply-all. On Sun, Mar 4, 2012 at 2:37 PM, Thomas Pedersen <thomas@xxxxxxxxxxx> wrote: > On Sat, Mar 3, 2012 at 3:37 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >> On Fri, 2012-03-02 at 15:46 -0800, Thomas Pedersen wrote: >>> Airtime link metric estimation was broken in HT mesh, use >>> cfg80211_calculate_bitrate to get the right rate value. >>> >>> Also factor out rate copying from sta_set_sinfo(). >>> >>> Signed-off-by: Thomas Pedersen <thomas@xxxxxxxxxxx> >>> --- >>> v2: >>> factor out rate copying (Johannes) >> >>> +void sta_set_rate_info(struct sta_info *sta, struct station_info *sinfo) >> >> For stack usage, it'd be better if you gave this two arguments (struct >> rate_info *txrate, struct rate_info *rxrate), or maybe simply factored >> out *only* the TX-rate bit? >> > > like sta_set_rate_info(struct sta_info *sta, struct rate_info *txrate, > struct rate_info *rxrate)? > > How do you feel about consolidating last_rx_flags and _index into an > ieee80211_tx_rate? A bit odd maybe, but then we could use: > > sta_set_rate_info(struct ieee80211_tx_rate *rate, struct rate_info *rinfo); > > As needed for both last_rx and last_tx rates. > > Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
