Search Linux Wireless

Re: [PATCH] cfg80211: Add an attribute to set inactivity timeout in AP mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 02, 2012 at 10:01:24AM +0100, Johannes Berg wrote:
> Hi Vasanth,
> 
> On Thu, 2012-03-01 at 20:51 +0530, Vasanthakumar Thiagarajan wrote:
> > + * @NL80211_ATTR_INACTIVITY_TIMER_SUPPORT: Indicates if the driver has the
> > + *	capability to use %NL80211_ATTR_INACTIVITY_TIMEOUT for freeing up
> > + *	connected stations.
> 
> I think now that we have "enum nl80211_feature_flags" you could just add
> a flag to it.

Good point, thanks.

> 
> > + * @NL80211_ATTR_INACTIVITY_TIMEOUT: timeout value in seconds, this can be
> > + *	used by the drivers which has MLME in firmware and does not have support
> > + *	to report per station tx/rx activity to free up the staion entry from
> > + *	the list. This should not be sent from userspace when the driver does
> > + *	not register it's capability to timeout the stations.
> 
> Shouldn't that be the other way around -- it needs to be used when the
> driver *does* advertise support for it?
> 
Ah, right, thanks.

> 
> > +	WIPHY_FLAG_SUPPORTS_INACTIVITY_TIMER	= BIT(22),
> 
> If you use nl80211_feature_flags you also don't need this wiphy to
> feature translation, the driver can directly set those flags.

Right.

Vasanth
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux