Search Linux Wireless

Re: [PATCH] mac80211 radiotap injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 23, 2012 at 10:47 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Thu, 2012-02-23 at 10:45 -0800, Sam Leffler wrote:

>> >> + * @IEEE80211_TX_CTL_NO_RC: This frame does not require rate control.
>> >> + *   This flag is used when an injected frame includes a transmit
>> >> + *   rate (and possibly flags and retry count) in the radiotap header.
>> >
>> > Does that really have to be here? This is the last bit we have, and it
>> > seems this is internal so ... ?
>>
>> So ... what?  I saw it was the last bit didn't see another way to tag
>> state in the skb (and the cb looked to be max size so there was no
>> room to expand it).
>
> I was thinking it could be in struct ieee80211_tx_data.flags?

I don't see how to get a handle on a ieee80211_tx_data struct in
ieee80211_monitor_start_xmit.  It looks like the tx path allocates it
on the stack for all the subhandlers but this is called through the
netdevice ops vector.

I'll revise the original patch and let Lars work on his separate
change for tx power.

-Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux