On Thu, 2012-02-23 at 10:45 -0800, Sam Leffler wrote: > > Please read > > http://wireless.kernel.org/en/developers/Documentation/SubmittingPatches, particularly the references at the bottom of the page. > > > > Please also follow the style of the surrounding code. > > I tried (for my stuff); it's helpful if you can point out at least one > specific issue. The code went through checkpatch for example. Commit log for instance, in this particular patch. > >> IEEE80211_RADIOTAP_F_FRAG: frame will be fragmented if longer than the > >> current fragmentation threshold. > >> > >> + * IEEE80211_RADIOTAP_RATE > >> + legacy transmit rate in .5 Mb/s units (u8) > > > > This looks quite strange, for example. > > Strange how? The .5 units are consistent w/ IEEE legacy rate codes. > Not sure how you want to express values like 5.5 to the kernel. Oh, just the formatting -- the above is indented, this isn't. > >> + * @IEEE80211_TX_CTL_NO_RC: This frame does not require rate control. > >> + * This flag is used when an injected frame includes a transmit > >> + * rate (and possibly flags and retry count) in the radiotap header. > > > > Does that really have to be here? This is the last bit we have, and it > > seems this is internal so ... ? > > So ... what? I saw it was the last bit didn't see another way to tag > state in the skb (and the cb looked to be max size so there was no > room to expand it). I was thinking it could be in struct ieee80211_tx_data.flags? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
