On Sun, 2012-02-19 at 01:30 +0000, Ben Hutchings wrote: > On Fri, 2012-02-17 at 17:41 +0200, Luciano Coelho wrote: > > Hi Ben, > > > > Please pull the latest firmwares for the wl12xx driver. These are new > > firmwares that are necessary to use the latest driver version, in which > > the host/fw API has changed. We also updated our licence file. > > > > Please let me know if there are any problems. > > There are. :) > [...] > > diff --git a/LICENCE.ti-connectivity b/LICENCE.ti-connectivity > > index 085f6c7..da80b62 100644 > > --- a/LICENCE.ti-connectivity > > +++ b/LICENCE.ti-connectivity > > @@ -1,151 +1,46 @@ > [...] > > + 1 TECHNOLOGY AND SOFTWARE PUBLICLY AVAILABLE > > + 2 SOFTWARE LICENSE > > + 3 > > What's with the line numbers here? I don't really know, it's ugly, but that's what we got from legal. I saw it but didn't dare change, I'll recheck with legal to see if that is really required or not. > [...] > > diff --git a/WHENCE b/WHENCE > > index 804c91f..0596204 100644 > > --- a/WHENCE > > +++ b/WHENCE > [...] > > + Single-role: wl127x-fw-4-sr.bin 6.3.5.0.98 > > + Multi-role: wl127x-fw-4-mr.bin 6.5.2.0.15 > > + PLT: wl127x-fw-4-plt.bin 6.3.5.0.98 > > + Single-role: wl128x-fw-4-sr.bin 7.3.5.0.98 > > + Multi-role: wl128x-fw-4-mr.bin 7.5.2.0.15 > > + PLT: wl128x-fw-4-plt.bin 7.3.5.0.98 > [...] > > This is not the correct format for version information. I'm going to > insist that for the new files you put a 'Version' field under each > 'File' field. Please also convert the existing version information in a > separate commit. Okay, I'll use the correct format and resend. I'll also add a patch to fix the existing ones. I'm the new "pusher" of firmwares from TI, so please bear with me while I adapt and learn the correct rules for linux-firmware.git. ;) Thanks a lot for the comments! -- Cheers, Luca.
Attachment:
signature.asc
Description: This is a digitally signed message part
