On Tue, Jan 31, 2012 at 9:50 AM, Kalle Valo <kvalo@xxxxxxxxxx> wrote: > Eliad Peller <eliad@xxxxxxxxxx> writes: > >> On Mon, Jan 30, 2012 at 3:29 PM, Kalle Valo <kvalo@xxxxxxxxxx> wrote: >>> Eliad Peller <eliad@xxxxxxxxxx> writes: >>> >>>> The fw api was changed in the latest FWs (6.3.5.0.95 for wl127x >>>> and 7.3.5.0.95 for wl128x). >>>> >>>> Along with some small adjustments, the main changes >>>> inroduced by this patheset are configuring the >>>> templates per-role, and moving to IEEE80211_HW_SUPPORTS_DYNAMIC_PS >>>> mode. >>> >>> I didn't look so carefully, but doesn't this break bisect? I mean if you >>> change the firmware api in small patches wl12xx can't work properly >>> until all patches are applied, right? >>> >>> I would say that a huge patch doing all the necessary changes in one go >>> is better, even it's ugly. >>> >> yes. it will break bisect (although it shouldn't break compilations). >> i guess it's a matter of taste, but i think keeping the patches >> manageable is more important than being able to bisect. > > Yeah, it's just matter of taste. It's easy to skip commits during bisect > but someone not familiar with wl12xx does not know what commits to > skip and that will cause problems. > > But I don't care how you do it, I just wanted to point out this aspect :) > ok, thanks :) i took Luca's approach, and added an error message to the driver, and prevented it from starting in the transitional commits. i'll send an updated patchset soon. Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
