Search Linux Wireless

Re: [PATCH 00/12] wl12xx: update fw api

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 30, 2012 at 3:29 PM, Kalle Valo <kvalo@xxxxxxxxxx> wrote:
> Eliad Peller <eliad@xxxxxxxxxx> writes:
>
>> The fw api was changed in the latest FWs (6.3.5.0.95 for wl127x
>> and 7.3.5.0.95 for wl128x).
>>
>> Along with some small adjustments, the main changes
>> inroduced by this patheset are configuring the
>> templates per-role, and moving to IEEE80211_HW_SUPPORTS_DYNAMIC_PS
>> mode.
>
> I didn't look so carefully, but doesn't this break bisect? I mean if you
> change the firmware api in small patches wl12xx can't work properly
> until all patches are applied, right?
>
> I would say that a huge patch doing all the necessary changes in one go
> is better, even it's ugly.
>
yes. it will break bisect (although it shouldn't break compilations).
i guess it's a matter of taste, but i think keeping the patches
manageable is more important than being able to bisect.

Eliad.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux