On Tue, 2012-01-17 at 14:51 +1100, Julian Calaby wrote: > On Tue, Jan 17, 2012 at 14:48, Luciano Coelho <coelho@xxxxxx> wrote: > > On Tue, 2012-01-17 at 11:46 +1100, Julian Calaby wrote: > >> > + /* in wl127x we have the MAC address if the PG is >= (3, 1) */ > >> > + if (major == 3 && minor >= 1) > >> > >> Is this test correct? Do only major == 3 PGs support this command? > > > > Yes, major == 3 and minor greater than or equal to 1. Actually, there > > can't be a major greater than 3, because it's only 2 bits, so 3 is the > > maximum value. > > Just wanted to check as it seemed odd compared to the block for the > WL128X parts. I'm guessing TI never expected these parts to last long > enough to have more than 3 major revisions =) Yeah, and 16 HW revisions in total is usually more than enough. And, if really needed, there may be some bits elsewhere to be used. I understand your point and I actually had a similar check as for wl128x, but then I realized the "major >= 3" was useless and removed it. Thanks for looking into this! :) -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
