Search Linux Wireless

Re: [PATCH] NFC: Add NCI data exchange timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ilan,

A couple of nitpicks:

On Sun, 2012-01-08 at 14:11 +0200, ilanelias78@xxxxxxxxx wrote:

> @@ -454,8 +464,10 @@ static int nci_data_exchange(struct nfc_dev *nfc_dev, __u32 target_idx,
>  		return -EINVAL;
>  	}
>  
> -	if (test_and_set_bit(NCI_DATA_EXCHANGE, &ndev->flags))
> +	if (test_and_set_bit(NCI_DATA_EXCHANGE, &ndev->flags)) {
> +		pr_err("unable to exchange data, already in progress\n");
This is not really related to that patch.

> @@ -473,6 +485,8 @@ static struct nfc_ops nci_nfc_ops = {
>  	.dev_down = nci_dev_down,
>  	.start_poll = nci_start_poll,
>  	.stop_poll = nci_stop_poll,
> +	.dep_link_up = NULL,
> +	.dep_link_down = NULL,
Ditto.

Cheers,
Samuel.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux