Search Linux Wireless

Re: [PATCHv2 2/2] mac80211: add support for mcs masks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-01-10 at 18:28 +0100, Simon Wunderlich wrote:
> Hello Johannes,

> > All this logic is pretty complex, maybe we could translate the bitmap to
> > an array of unsigned longs and use test_bit() instead of open-coding it
> > for 8-bit words?
> 
> Mhm, I would rather not add further copies into this fast path function, and
> simply casting will result in bad behaviour (alignment, endianess). 

Well you don't want to copy it, you want to maintain the data that way,
I think? Ok I think I see -- you're concerned about the masking etc.
Dunno. Maybe at least there's a way to abstract out all the
calculations?

> Generally
> changing the mcs_mask to u32 is possible,

No, u64 might work today but maybe somebody will want to use higher
MCSes in the future?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux