Search Linux Wireless

Re: [PATCHv2 2/2] mac80211: add support for mcs masks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2012-01-05 at 20:58 +0100, Simon Wunderlich wrote:

> +static bool rate_idx_match_mcs_mask(struct ieee80211_tx_rate *rate,
> +				    u8 mcs_mask[IEEE80211_HT_MCS_MASK_LEN])
> +{
> +	int i, j;
> +	int ridx, rbit;
> +
> +	ridx = rate->idx / 8;
> +	rbit = rate->idx % 8;
> +
> +	/* sanity check */
> +	if (ridx < 0 || ridx > IEEE80211_HT_MCS_MASK_LEN)
> +		return false;
> +
> +	/* See whether the selected rate or anything below it is allowed. */
> +	for (i = ridx; i >= 0; i--) {
> +		for (j = rbit; j >= 0; j--)
> +			if (mcs_mask[i] & BIT(j)) {
> +				rate->idx = i * 8 + j;
> +				return true;
> +			}
> +		rbit = 7;
> +	}
> +
> +	/* Try to find a higher rate that would be allowed */
> +	ridx = (rate->idx + 1) / 8;
> +	rbit = (rate->idx + 1) % 8;
> +
> +	for (i = ridx; i < IEEE80211_HT_MCS_MASK_LEN; i++) {
> +		for (j = rbit; j < 8; j++)
> +			if (mcs_mask[i] & BIT(j)) {
> +				rate->idx = i * 8 + j;
> +				return true;
> +			}
> +		rbit = 0;
> +	}
> +	return false;

All this logic is pretty complex, maybe we could translate the bitmap to
an array of unsigned longs and use test_bit() instead of open-coding it
for 8-bit words?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux