Hi, > > Maybe we could update all stations in the slow-path (changes in the HT > > mask) and then just use the already masked version in the sta entry in > > the fastpath here? > > You are right that this definitly adds some load on the fastpath (Although > I don't know how much the compiler optimizes here anyway, its only 10 bytes > which are set and masked). > > Currently I see two approaches here: > > 1.) move the masking into the station handling code (when a new station joins). > We would also need to iterate over the connected station when changing > the mcs_mask while the interface is up. > --> this will probably need to change at quite some palces and might be race-risky Yeah this is what I was thinking of, but you could well be right that it might be quite hard to do. > 2.) keep the masking in the rate_control_get_rate() function, but mask only > once (first time) and keep the result in the station struct. Next time we > enter it, we use the already masked result. We could then use a flag to > remember that we already computed the mask and just use it, and another > flag to signalize if the mcs_mask was modified externally > --> this is not racy and rather simple, but adds some flags I don't really like that, it's just as much complexity really and you need to still iterate all stations to invalidate the flag if mcs_mask was changed. Better just keep it as is unless we find it's a problem. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
