Search Linux Wireless

Re: [RFC] mac80211: fix scan state machine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 21 December 2011 09:01 PM, Helmut Schaa wrote:
Hi,

Hi Helmut,


On Wed, Dec 21, 2011 at 3:51 PM, Mohammed Shafi Shajakhan
<mohammed@xxxxxxxxxxxxxxxx>  wrote:
From: Mohammed Shafi Shajakhan<mohammed@xxxxxxxxxxxxxxxx>

when we run high bandwidth UDP traffic and we trigger a scan, the scan
state machine seems to be looping in SUSPEND->RESUME->DECISION->SUSPEND
and SET_CHANNEL seems to be never called as 'tx_empty' is never true
while running UDP traffic. fix this by settting SET_CHANNEL state when
we get into RESUME state.

Your analysis looks correct to me. Previously (before the
simplification patches)
the logic to always scan at least one channel was put in scan_state_decision but
maybe it makes sense to have it in scan_state_resume.

thanks for the review.
i compared "ieee80211_scan_state_resume" with the older code's
"ieee80211_scan_state_leave_oper_channel"


So, to me the patch looks good.

Helmut



--
thanks,
shafi
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux