Hi, On Wed, Dec 21, 2011 at 3:51 PM, Mohammed Shafi Shajakhan <mohammed@xxxxxxxxxxxxxxxx> wrote: > From: Mohammed Shafi Shajakhan <mohammed@xxxxxxxxxxxxxxxx> > > when we run high bandwidth UDP traffic and we trigger a scan, the scan > state machine seems to be looping in SUSPEND->RESUME->DECISION->SUSPEND > and SET_CHANNEL seems to be never called as 'tx_empty' is never true > while running UDP traffic. fix this by settting SET_CHANNEL state when > we get into RESUME state. Your analysis looks correct to me. Previously (before the simplification patches) the logic to always scan at least one channel was put in scan_state_decision but maybe it makes sense to have it in scan_state_resume. So, to me the patch looks good. Helmut > Signed-off-by: Mohammed Shafi Shajakhan <mohammed@xxxxxxxxxxxxxxxx> > --- > net/mac80211/scan.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c > index 2c5041c..2908e56 100644 > --- a/net/mac80211/scan.c > +++ b/net/mac80211/scan.c > @@ -625,7 +625,7 @@ static void ieee80211_scan_state_resume(struct ieee80211_local *local, > local->leave_oper_channel_time = jiffies; > > /* advance to the next channel to be scanned */ > - local->next_scan_state = SCAN_DECISION; > + local->next_scan_state = SCAN_SET_CHANNEL; > } > > void ieee80211_scan_work(struct work_struct *work) > -- > 1.7.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
