Hi Kalle,
On Thu, 2011-12-01 at 13:23 +0200, Kalle Valo wrote:
> Pontus Fuchs <pontus.fuchs@xxxxxxxxx> writes:
>
> > Commit 80900d0140a7648587982c8f299830e900e49165 accidently broke
> > the ABI for testmode commands. Restore the ABI again.
> >
>
> [...]
>
> > --- a/drivers/net/wireless/wl12xx/testmode.c
> > +++ b/drivers/net/wireless/wl12xx/testmode.c
> > @@ -37,6 +37,7 @@ enum wl1271_tm_commands {
> > WL1271_TM_CMD_TEST,
> > WL1271_TM_CMD_INTERROGATE,
> > WL1271_TM_CMD_CONFIGURE,
> > + WL1271_TM_CMD_NVS_PUSH, /* Not in use. Keep to not break ABI */
>
> Better to call it WL1271_TM_CMD_UNUSED1, or something like that, so that
> it really stays unused.
As we discussed briefly on IRC, I think it's a better idea to keep it as
is. If anyone still uses it (despite the comment saying it's not in
use), we will return -EOPNOTSUPP.
--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
