Search Linux Wireless

Re: [PATCH] mac80211: Do not request FIF_BCN_PRBRESP_PROMISC for HW scan.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2011-12-12 at 10:31 +0100, Dmitry Tarnyagin wrote:
> On Mon, Dec 12, 2011 at 10:00 AM, Johannes Berg
> <johannes@xxxxxxxxxxxxxxxx> wrote:
> > On Sun, 2011-12-11 at 22:47 +0100, Dmitry Tarnyagin wrote:
> >> ieee80211_configure_filter code used local->scanning as a boolean value
> >> when it was a bit mask. Bits SCAN_HW_SCANNING, SCAN_COMPLETED, SCAN_ABORTED
> >> should not set FIF_BCN_PRBRESP_PROMISC filter.
> >
> > Seems right -- although the probresp-promisc filter thing is debatable
> > and I think the changelog should be more explicit about it, maybe saying
> > that the driver can always change that by itself in the hw scan callback
> > if it requires it... That part isn't really only bugfix, it's a semantic
> > change.
> >
> Well, then the semantic should be at least consistent. Scan code does
> not specially
> configure filter for hw scans, nor after scan complete. But any 3rd
> party config-filter
> requests during an active scan enable probresp-promisc.

Yeah, and I don't disagree with this change -- all I'm saying is that
the commit log should reflect that because otherwise somebody later
looking at this change will be scratching their head :)

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux